refactor(editor): Enable @typescript-eslint/no-base-to-string lint rule, fix errors (no-changelog) #9783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
netroy
approved these changes
Jun 18, 2024
| @@ -132,7 +132,11 @@ const outputTypeParsers: { | |||
| } else if (content.id.includes('SystemMessage')) { | |||
| message = `**System Message:** ${message}`; | |||
| } | |||
| if (execData.action && execData.action !== 'getMessages') { | |||
| if ( | |||
There was a problem hiding this comment.
this is good enough as a short-term solution, but in the long-term we really need to use a lot less of IDataObject. If execData was to use proper typing, we wouldn't need hacky checks like these.
|
✅ No visual regressions found. |
2 flaky tests on run #5548 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
10-undo-redo.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo renaming node using NDV |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9783 ↗︎
|
✅ All Cypress E2E specs passed |
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
…le, fix errors (no-changelog) (n8n-io#9783)
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
…le, fix errors (no-changelog) (n8n-io#9783)
|
Got released with |
1 similar comment
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable @typescript-eslint/no-base-to-string lint rule, fix errors
Recently a bug: #9782 could have been prevented by this rule
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)